Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 84.52% 84.56% +0.04%
==========================================
Files 57 57
Lines 2591 2682 +91
Branches 332 347 +15
==========================================
+ Hits 2190 2268 +78
- Misses 401 414 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oruebel
marked this pull request as ready for review
July 13, 2026 06:37
…ods to make search by name easier
…:findOwnedObject functions
Imports the remfile-cpp package (https://github.com/bendichter/remfile-cpp, a C++ port of the Python remfile package) as an optional CMake dependency and adds HDF5IO::openRemote() to open remote files with it. Unlike ROS3, the remfile VFD does not require HDF5 to be built with ROS3 support and works with any HTTP(S) server that supports byte-range requests. The ros3_benchmark demo accepts an optional driver argument (ros3 | remfile) so the two drivers can be benchmarked head-to-head, and CI runs the demo with both. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Completed review |
Add remfile VFD for reading remote files over HTTP(S)
…rk_demo Add ros3 benchmark demo
oruebel
commented
Jul 24, 2026
oruebel
commented
Jul 24, 2026
| FetchContent_Declare( | ||
| remfile | ||
| GIT_REPOSITORY https://github.com/catalystneuro/remfile-cpp.git | ||
| # GIT_TAG v0.1.2 |
Contributor
Author
There was a problem hiding this comment.
Need to fix the GIT_TAG once remfile-cpp has been released with the fix. The GIT_TAG has been removed for now in order to confirm with the dev version that this is working.
Suggested change
| # GIT_TAG v0.1.2 | |
| GIT_TAG v0.1.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDF5IO.open_s3methodHDF5IO.canModifyObjectto work with ROS3Changes from #308
BaseIO::findObjectandRegisteredType::findOwnedObjectmethods to simplify searching for objects by nameHDF5IO::findObjectto improve search performanceinstall-config.cmaketo propagate HDF5 include directories to downstream consumers of theaqnwb::aqnwbtarget, allowing them to locate HDF5 headers regardless of where HDF5 is installed on the system.Changes from #309
HDF5IO::openRemote()method to read remote NWB files over HTTP(S) using the remfile-cpp virtual file driver (a C++ port of the Python remfile package), imported as an optional CMake dependency (AQNWB_USE_REMFILE, ON by default on non-Windows platforms; requires libcurl). Unlike ROS3, remfile does not require HDF5 to be built with ROS3 support and works with any HTTP(S) server that supports byte-range requests. Theros3_benchmarkdemo accepts an optional driver argument (ros3orremfile) to compare the two.Changes after merging the different PR's
CMakeListsto use themainbranch instead of the pinned version0.1.2which failed on Windowsdemo/ros3_benchmarktodemo/remote_read_benchmarksince it now covers both remfile and ros3NOTE: The ROS3 unit test and example are currently only run in CI in the Ubuntu tests. MacOS and Windows CI do not install HDF5 with ROS3 support enabled by default. However, testing on one platform should be sufficient for this feature and this also confirms that the optional build with ROS3 works. So no changes to the CI needed.
NOTE: the failing CI for
[Test generating classes from schema files / run-scripts (pull_request)]is due to changes in the NWB 2.10 schema and has been addressed separately in this PR #300 .