fix(opsec): block Ghidra RE artifacts + clear ruff backlog + doc fixes#106
Merged
Conversation
…nsistency fixes Opsec (HIGH): .gitignore + scripts/githooks/pre-commit now block pyghidra/Ghidra output (pyghidra_mcp_projects/, *ghidra*, *.gpr, *.rep) — previously neither did, so 'git add .' could publish RE artifacts to the public repo. Added a regression test (opsec guard suite 6 -> 7 passing). gitignore: also ignore .wrangler/ and uv.lock; de-duplicate .DS_Store. ruff: auto-fixed 74 of 94 backlog issues across 23 modules (no __init__ touched, so no broken re-exports); full suite green (1,584 passing, 2 skipped). 19 manual issues remain (unused vars, import-order, ambiguous names). docs: ROADMAP.md HISTORICAL banner (it predated the v0.x pivot / '27 tests'); README test count 1,285 -> 1,586 + badge; split a glued 'Known limitations' bullet; AGENTS.md stale tool names (list_files/read_file/set_plan -> Glob/Grep/Read). assets: moved unreferenced korgex-chrome-light.png -> docs/images/.
A self-contained, no-dependency HTML overview written for non-technical readers: what korgex is, the verifiable-record idea (via a plain logbook analogy), what it can do, a 60-second quickstart, and safety. Public-safe (korgex only). Open in any browser.
Cleared the non-auto-fixable ruff backlog in src/: - removed 7 dead local variables (diff_engine, interactive, sandbox, self_healing, system_prompt, tools_impl, webhook_server) - split 2 semicolon statements (agent.py streaming spinners) - renamed 3 ambiguous 'l' loop vars -> ln/lbl (korgantic, memory, webhook_server) - dropped 1 unused import (dashboard: fastapi.HTTPException) - marked 6 deliberate import-after-defs with '# noqa: E402 (<reason>)' (tool-registration / circular-import-avoidance patterns) 'ruff check src/' is now clean; added a 'lint' job to tests.yml so it stays that way. Full suite green (1,584 passing, 2 skipped).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opsec + housekeeping fixes from a codebase review. Three commits:
.gitignoreand thescripts/githooks/pre-commitOPSEC guard now block Ghidra / pyghidra-mcp output (*.gpr,*.rep,pyghidra_mcp_projects/). Previously neither did, sogit add .could publish reverse-engineering artifacts to this public repo. Includes a regression test (opsec guard 6 → 7 passing). Also ignores.wrangler/+uv.lock, de-dups.DS_Store, and ranruff --fixon the auto-fixable backlog.docs/korgex-explained.htmloverview;ROADMAP.mdmarked HISTORICAL (it predated the v0.x pivot); README test count fixed + badge bumped to 1,586; split a glued limitations bullet;AGENTS.mdtool names corrected. Moved a stray PNG intodocs/images/.src/and added alintjob to CI soruff check src/stays green.Test plan
ruff check src/→ All checks passed.gpr+ "ghidra" content are blocked__init__.pytouched by ruff --fix (no broken re-exports)