Skip to content

Conversation

@NicBOMB
Copy link
Contributor

@NicBOMB NicBOMB commented Sep 25, 2022

Vortex will continue depending on node-gyp "^7.1.2" and not running on Linux until a new github release is created.

Vortex will continue depending on `node-gyp "^7.1.2"` and not running on Linux until a new github release is created.
@TanninOne
Copy link
Contributor

What is the point of this PR?

@NicBOMB
Copy link
Contributor Author

NicBOMB commented Oct 9, 2022

What is the point of this PR?

Vortex/extensions/gameversion-hash needs a new vortexmt release to build on Linux.
Specifically, the build error is the same node-gyp error as before

$ yarn install
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "@types/redux-thunk > redux-thunk@2.4.1" has unmet peer dependency "redux@^4".
[4/4] Building fresh packages...
error /GitHub/Nexus-Mods/Vortex/extensions/gameversion-hash/node_modules/vortexmt: Command failed.
Exit code: 1
Command: prebuild-install -r napi -t 4 -a x64 || node-gyp rebuild
Arguments: 
Directory: /GitHub/Nexus-Mods/Vortex/extensions/gameversion-hash/node_modules/vortexmt
Output:
prebuild-install WARN install No prebuilt binaries found (target=4 runtime=napi arch=x64 libc= platform=linux)
gyp info it worked if it ends with ok
gyp info using node-gyp@7.1.2
gyp info using node@18.10.0 | linux | x64
gyp info find Python using Python version 3.10.7 found at "/usr/bin/python3"
(node:141591) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
(Use `node --trace-deprecation ...` to show where the warning was created)
gyp info spawn /usr/bin/python3
gyp info spawn args [
gyp info spawn args   '/GitHub/Nexus-Mods/Vortex/extensions/gameversion-hash/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/GitHub/Nexus-Mods/Vortex/extensions/gameversion-hash/node_modules/vortexmt/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/GitHub/Nexus-Mods/Vortex/extensions/gameversion-hash/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '~/.cache/node-gyp/19.0.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=~/.cache/node-gyp/19.0.0',
gyp info spawn args   '-Dnode_gyp_dir=/GitHub/Nexus-Mods/Vortex/extensions/gameversion-hash/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=~/.cache/node-gyp/19.0.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/GitHub/Nexus-Mods/Vortex/extensions/gameversion-hash/node_modules/vortexmt',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp: name 'openssl_fips' is not defined while evaluating condition 'openssl_fips != ""' in binding.gyp while trying to load binding.gyp
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1

There is no prebuild for Linux, which is fine, but vortexmt is still using node-gyp@7.1.2 which we determined is outdated. Once a new release is made, other packages can update this module, which will include the update to node-gyp 9, allowing the build to continue and enabling more modules to build on non-Windows platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants