Skip to content

add zizmor and actionlint to treefmt config#402

Merged
MattSturgeon merged 3 commits into
NixOS:masterfrom
MattSturgeon:gha-lint
May 25, 2026
Merged

add zizmor and actionlint to treefmt config#402
MattSturgeon merged 3 commits into
NixOS:masterfrom
MattSturgeon:gha-lint

Conversation

@MattSturgeon
Copy link
Copy Markdown
Contributor

@MattSturgeon MattSturgeon commented May 22, 2026

Followup to #399, blocked by updating the nixpkgs revision (#389)

I've not run zizmor or actionlint against the workflow files yet.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Nixpkgs diff

@jfly jfly marked this pull request as ready for review May 25, 2026 16:13
@jfly jfly changed the title [draft] add zizmor and actionlint to treefmt config add zizmor and actionlint to treefmt config May 25, 2026
@jfly jfly force-pushed the gha-lint branch 2 times, most recently from 082c4ef to 5b1588d Compare May 25, 2026 16:39
@jfly
Copy link
Copy Markdown
Collaborator

jfly commented May 25, 2026

@MattSturgeon, I've rebased this PR, locked the latest version of treefmt-nix, and fixed the issues actionlint complained about.

I also discovered that we're not compatible with the latest version of serokell-nix. I've filed #405 to track that.

@jfly
Copy link
Copy Markdown
Collaborator

jfly commented May 25, 2026

@MattSturgeon, rebased for the last time. Could you take a look and merge when ready?

Copy link
Copy Markdown
Contributor Author

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve my own PR, but your pushes LGTM.

@MattSturgeon MattSturgeon merged commit 273c857 into NixOS:master May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants