Skip to content

icu73: use buildPackages.icu73 for nativeBuildRoot#289782

Closed
afh wants to merge 1 commit into
NixOS:stagingfrom
afh:fix-icu73
Closed

icu73: use buildPackages.icu73 for nativeBuildRoot#289782
afh wants to merge 1 commit into
NixOS:stagingfrom
afh:fix-icu73

Conversation

@afh

@afh afh commented Feb 18, 2024

Copy link
Copy Markdown
Member

Description of changes

I might be missing something, yet it seems the icu73 package definition in all-packages.nix may have a typo as it uses buildPackages.icu72 instead of buildPackages.icu73 as its nativeBuildRoot.

ℹ️ This PR should possibly be closed in favour of #289814 if that PR is headed in the right direction.

Do let me know if this is an actual issue and if yes, whether staging is the correct merge base for this PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 18, 2024
@afh afh mentioned this pull request Feb 18, 2024
15 tasks
@afh

afh commented Feb 18, 2024

Copy link
Copy Markdown
Member Author

ℹ️ icu73, icu73.passthru.tests on x86_64-darwin failed due to: error: building of '/nix/store/a8fnjl2ak7c87j8scxjnj5yj62z7a8qn-llvm-16.0.6.drv^dev' from .drv file timed out after 3600 seconds

@afh afh marked this pull request as draft February 19, 2024 16:49
@afh afh mentioned this pull request Feb 20, 2024
15 tasks
@afh

afh commented Feb 21, 2024

Copy link
Copy Markdown
Member Author

Closing as this PR is obsoleted by merged #290266.

@afh afh closed this Feb 21, 2024
@afh afh deleted the fix-icu73 branch February 21, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant