icu: 73.2 -> 74.2

[afh]

https://icu.unicode.org/download/74

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[kirillrdy]

cc @mweinelt

[afh]

Obsoleted by #290266

[7c6f434c]

Obsoleted in what sense??

[afh]

My sincerest apologies, I must've had a complete 🧠😶‍🌫️ earlier today.

[marsam]

@GrahamcOfBorg eval

[afh]

Friendly ping to @mweinelt, @AndersonTorres, @anthonyroussel on this 🙂

[AndersonTorres]

A mere change of defaults? Well, let's wait ofBorg then.

[afh]

Seems like all checks except for tests on x86_64-darwin have passed, not sure if these are related.

[AndersonTorres]

ARM Darwin passed.

[7c6f434c]

Darwin failure is LLVM timeout on staging (which is a stdenv dependency), this is not specific to this PR (and there is some work being done on ofBorg side to find a proper solution to this in the medium term)

[7c6f434c]

Note that ofBorg does not do a full reverse-dependency build so maybe if someone can guess possibly-fragile packages for ICU version bump we should ofborg-build them explicitly.

[AndersonTorres]

Note that ofBorg does not do a full reverse-dependency build so maybe if someone can guess possibly-fragile packages for ICU version bump we should ofborg-build them explicitly.

About this, can we create some test suite, maybe in the form of a NixOS Test Module?

[7c6f434c]

Whatever packages we want to be built, can be added to passthru.tests directly as packages. If you have a command-line check in mind, we can add it there as a runCommandNoCC expression. If we want to test something with a GUI, then yes, NixOS test might be needed…

[AndersonTorres]

Whatever packages we want to be built, can be added to passthru.tests directly as packages.

This can be easy for some leaf packages like we do with live555-vlc.
But for things like, say, a statistical sample of 10 packages, I believe we should use something more structured.

[afh]

In regards to testing is there anything that you, @AndersonTorres and @7c6f434c, would like to see get added with this PR or should an issue be created that tracks the work?

[AndersonTorres]

This can be done later.
For now let's work on make this PR merged before the end-of-year release :)

[7c6f434c]

@ofborg build cfdg python3Packages.pyicu xfsprogs vte libical

[afh]

Unfortunately the failing ofborg builds failed due to a timeout trying to build llvm-16. Anything that could be done to address this?

error: building of '/nix/store/03390naaq49frd957nhj31b61a33v8m9-llvm-16.0.6.drv^dev' from .drv file timed out after 3600 seconds

[7c6f434c]

Not really, Darwin + staging often ends up impossible to check on ofBorg due to stdenv being too heavy…

[afh]

Thanks for your insightful comments and for merging, @AndersonTorres and @7c6f434c, very much appreciated.
Feel free to cc me on any issue you may create in regards to icu-related tests, I'd be happy to follow the conversation.