nextcloud32.packages.apps.gpoddersync: init at 3.13.1

[x10an14]

Added gpoddersync nextcloud app to NC 32, as discussed here: #446632 (comment)

Here's changelog: https://github.com/thrillfall/nextcloud-gpodder/releases/tag/3.13

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[x10an14]

Awaiting nixpkgs-review rev HEAD with amended commit adding the missing final 2 (not just 1x) \n at the end of file - thus passing nix fmt.

It's been running for 12 mins and counting.

[x10an14]

It's been running for 12 mins and counting.

25+ mins and counting. Headed to bed, will test on NC 32 instance tomorrow.

[dotlambda]

Please run pkgs/servers/nextcloud/packages/generate.sh.

[x10an14]

Please run pkgs/servers/nextcloud/packages/generate.sh.

Done. Next is testing for me, then I'm satisfied.

Let me know if I forgot anything/should do something else/more!

[x10an14]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450804
Commit: 55160731f4fa8d2d80920166f96d40d1f02a3dbb

[x10an14]

Done. Next is testing for me, then I'm satisfied.

Tested on my NC instance (v32 + gpoddersync).
Works fine!

[dotlambda]

Why are there two commits?

[x10an14]

Why are there two commits?

Because you asked me to run #450804 (review), which touches other packages.
Without further context, abiding the https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md (since it touches other packages), that's what made sense to me.

Is there some documented instruction I've missed somewhere?

---

I can just squash the commits, but I'm awaiting thrillfall/nextcloud-gpodder#206 as requested by you.

[dotlambda]

If you really want two commits it's fine but then you need to make sure that the first adds only the one package exactly as the script would.

[x10an14]

This was a learning experience, but now I hope all is correct.

[dotlambda]

I manually built nextcloud31Packages.apps and nextcloud32Packages.apps.
Everything but hmr_enabler built successfully, see #435943 (comment).
I also ran nixosTests.nextcloud.

[x10an14]

(...) I also ran nixosTests.nextcloud.

Is there a way to do this with the new nix3 / experimental nix commands?
So far I've only found the nix-build --attrs way to do so, unless I hackily perform a nix eval --apply builtins.attrNames --json and iterate over the results.

Ref: NixOS/nix#7701 (comment)

[dotlambda]

@x10an14 nix build -f . nixosTests.nextcloud