Skip to content

python3Packages.av: fix build#518348

Closed
thunze wants to merge 1 commit into
NixOS:staging-nextfrom
thunze:av-fix-ffmpeg-8.1
Closed

python3Packages.av: fix build#518348
thunze wants to merge 1 commit into
NixOS:staging-nextfrom
thunze:av-fix-ffmpeg-8.1

Conversation

@thunze
Copy link
Copy Markdown
Member

@thunze thunze commented May 9, 2026

PyAV-Org/PyAV#2204
PyAV-Org/PyAV#2205

Hydra: https://hydra.nixos.org/build/328526004

Not bumping to 17.0.1 as that would be a breaking change and breaking changes are currently restricted.

Things done

  • Built on platform:
    • x86_64-linux — python3{13,14}Packages.av
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@thunze
python3Packages.av: fix build
e8308d0 
PyAV-Org/PyAV#2204
PyAV-Org/PyAV#2205

Hydra: https://hydra.nixos.org/build/328526004

Not bumping to 17.0.1 as that would be a breaking change and breaking
changes are restricted at the time of writing.
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels May 9, 2026
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented May 9, 2026 •
edited
Loading

I'm fine with bumping. The primary breaking change is proper error propagation IMO.

We would benefit from all the bugfixes. Can also run the nixpkgs-review for it.

#513194

@thunze
Copy link
Copy Markdown
Member Author

thunze commented May 9, 2026 •
edited
Loading

I was worried about

Save space by removing libaom (av1 encoder/decoder); dav1d, stvav1, and hardware, are available alternatives.

but I can't find any commit/issue/PR or anything in the upstream diff about it. Even pyav --codecs still shows it.

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented May 9, 2026

Are you then fine with closing? They are just reducing duplicate encoder support for the same codec.

@thunze
Copy link
Copy Markdown
Member Author

thunze commented May 9, 2026

Yeah, let's bump then.

@thunze thunze closed this May 9, 2026
@thunze thunze deleted the av-fix-ffmpeg-8.1 branch May 9, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thunze @mweinelt