Skip to content

ipykernel: fix permissions when installing kernels#51906

Merged
FRidh merged 1 commit into
NixOS:masterfrom
ecoughlan:ipykernel-chmod-fix
Dec 19, 2018
Merged

ipykernel: fix permissions when installing kernels#51906
FRidh merged 1 commit into
NixOS:masterfrom
ecoughlan:ipykernel-chmod-fix

Conversation

@ecoughlan

@ecoughlan ecoughlan commented Dec 12, 2018

Copy link
Copy Markdown
Motivation for this change

The /tmp path needs to be made user writable because copytree takes the permissions from the nix store.
Verify with: python -m ipykernel install --user --name=testkernel

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ecoughlan ecoughlan requested a review from FRidh as a code owner December 12, 2018 10:58
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 12, 2018
Comment thread pkgs/development/python-modules/ipykernel/ipykernel_writable_temp.patch Outdated
Comment thread pkgs/development/python-modules/ipykernel/default.nix Outdated
@FRidh FRidh merged commit 7c2d638 into NixOS:master Dec 19, 2018
@ecoughlan ecoughlan deleted the ipykernel-chmod-fix branch May 20, 2019 17:26
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants