Open
Conversation
Author
|
I want to merge this and later rebase the existing PRs that update dependencies on top of this to make sure elm tests still pass. |
jwoudenberg
approved these changes
Sep 3, 2019
Contributor
jwoudenberg
left a comment
jwoudenberg
left a comment
There was a problem hiding this comment.
I noticed that locally and in CI just elm-verify-examples runs but it doesn't run the Elm tests. Maybe this was intentional? I'm not familiar with elm-verify-examples and why would you want to run it without also running the tests.
Stoeffel would know, but he's on a holiday this week so I don't want to ping him now. My guess is that some people might want to just generate Elm tests for their comments and then commit them to their repo os something, running them in CI later.
At any rate, this seems great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that locally and in CI just
elm-verify-examplesruns but it doesn't run the Elm tests. Maybe this was intentional? I'm not familiar withelm-verify-examplesand why would you want to run it without also running the tests.