Draft
Conversation
This stores extra metadata for libretro cores, like sync settings. Bk2 files require specific sync settings, so it's required to open them. The `MovieFile` field is annotated with `#[serde(default)]` so that mvi can still open old movie files.
Most sync settings can be found in bizhawk sources at snes_init in waterbox/bsnescore/bsnes/target-bsnescore/bsnescore.cpp Some sync settings were not ported: - LimitAnalogChangeSensitivity: mouse-related setting which i dont know what is doing in bsnes sync settings - RegionOverride, UseRealTime and InitialTime: couldn't find the equivalent setting in bsnes' interface
Contributor
Author
|
Played a bk2 movie without passing environment variables to the bsnes core, and it seemed to sync well. haven't tried with longer movies yet 2026-01-30.00-02-37.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch i started long ago but doesn't work yet.
First commit (will) implement libretro environment variables to pass bk2 sync settings to bsnes. The second commit is for actual opening/saving bk2 files.
TODO
MovieFile, because 1/ bk2 uses sha1 instead of sha2, and 2/ mvi needs to differentiate them on save (not save it as a .mvi when opened as a .bk2)