[codex] Fix workspace artifact builds for Ponder and Next.js#43
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Noc2
marked this pull request as ready for review
June 10, 2026 14:05
Noc2
added a commit
that referenced
this pull request
Jun 10, 2026
Third review pass at 6bf5b90 (post PR #43). Documents 18 new non-tokenomics findings not in design-review-2026-06.md, each with a proposed fix: a stuck fee-withdrawal UI button, an indexer pending-fee derivation that overstates during the withdrawal window, the EIP-2935 seed-expiry window (~8191 blocks, not 256), a hardcoded USDC EIP-712 domain with no upgrade guard, the preview World ID v4 verifier ABI dependency, webhook/x402 agent-surface gaps, and assorted keeper/ops/CI cleanups. Confirms PR #43 resolved release blockers R1a/R1b and the contract-size gate; R1c remains open. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rateloop/contractsartifacts before Ponder starts so container boots can resolve@rateloop/contracts/abis.next buildso Vercel can resolve@rateloop/contracts,@rateloop/sdk, and@rateloop/agentssubpath exports.RoundVotingEnginegeneric role mutators so the deploy-profile bytecode stays below EIP-170.Why
Vercel/Railway-style installs can run service startup or Next.js builds without first producing the
distfiles that the publishable workspace package exports point to. That caused module resolution failures for@rateloop/contracts/*.Spec freshness
[spec-ok] The
RoundVotingEngineSolidity change removes genericDEFAULT_ADMIN_ROLErole mutation entrypoints only. It does not change voting, reveal, settlement, payout, or lifecycle behavior covered by the Certora specs.Validation
yarn workspace @rateloop/ponder test scripts/start.test.tsyarn ponder:check-typesyarn workspace @rateloop/contracts buildyarn workspace @rateloop/contracts testyarn workspace @rateloop/foundry lintmake check-contract-sizes DEPLOY_PROFILE=deploymake check-storage-layoutsforge test --match-path test/RoundVotingEngineBranches.t.solRATELOOP_E2E_PRODUCTION_BUILD=true NEXT_PUBLIC_RATELOOP_E2E_PRODUCTION_BUILD=true yarn workspace @rateloop/nextjs buildMerge status
Non-destructive
git merge-tree origin/main codex/fix-cluster-oracle-auditreported no conflicts before the branch was updated againstorigin/main.