Fix FrontendRegistry upgrade storage order#68
Merged
Conversation
Co-authored-by: David Hawig <Noc2@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: David Hawig <Noc2@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62fe94d7c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a critical upgrade-safety regression in
FrontendRegistrywhere the new access-recorder mappings were inserted before existing fee-accounting storage.Changes
accessRecorderForFrontendandfrontendForAccessRecorderafter existing fee-creditor / pending-withdrawal fields so they consume reserved gap slots.FrontendRegistrystorage-layout snapshot to preserve slots 9-14 for existing fee state.Testing
Describe how you tested your changes:
yarn foundry:test)yarn workspace @rateloop/foundry check:sizes)yarn next:lint)yarn next:check-types)yarn base-sepolia:check) when staging deployment/env wiring changedyarn base-mainnet:check) when production deployment/env wiring changednode scripts/run-node-tests.mjs packages/foundry/scripts-js/storageLayoutUpgradeSafety.test.js)yarn e2e:ci:appor focused Playwright spec)yarn startNote:
forgeis not installed in this runner, so compiler-backed Foundry/storage-layout checks could not be executed here.Security
Related Issues
Closes #