Fix RBTS timeout stake returns#69
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: David Hawig <Noc2@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a high-severity RBTS timeout fallback bug where a round could settle after the oracle snapshot timeout without marking revealed voter stakes as returned.
Changes
Testing
Describe how you tested your changes:
$HOME/.foundry/bin/forge test --offline --match-contract RoundVotingEngineBranchesTest --match-test test_RbtsSettlementTimeoutReturnsRevealedStake -vvv$HOME/.foundry/bin/forge test --offline --match-contract RoundVotingEngineBranchesTest --match-test 'test_Rbts'yarn foundry:test)yarn workspace @rateloop/foundry check:sizes)yarn next:lint)yarn next:check-types)yarn base-sepolia:check) when staging deployment/env wiring changedyarn base-mainnet:check) when production deployment/env wiring changedyarn test:tsor focusednode scripts/run-node-tests.mjs ...)yarn e2e:ci:appor focused Playwright spec)yarn startSecurity
Related Issues
Closes #