Skip to content

Fix RBTS timeout stake returns#69

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/critical-bug-management-ba59
Draft

Fix RBTS timeout stake returns#69
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/critical-bug-management-ba59

Conversation

@cursor

@cursor cursor Bot commented Jul 2, 2026

Copy link
Copy Markdown

Description

Fixes a high-severity RBTS timeout fallback bug where a round could settle after the oracle snapshot timeout without marking revealed voter stakes as returned.

Changes

  • Return all revealed commit stakes on the empty-snapshot RBTS timeout path.
  • Keep normal finalized snapshot/no-forfeit behavior weight-gated.
  • Add a regression covering timeout settlement and subsequent voter stake claims.

Testing

Describe how you tested your changes:

  • Foundry focused regression passes: $HOME/.foundry/bin/forge test --offline --match-contract RoundVotingEngineBranchesTest --match-test test_RbtsSettlementTimeoutReturnsRevealedStake -vvv
  • Related RBTS subset passes: $HOME/.foundry/bin/forge test --offline --match-contract RoundVotingEngineBranchesTest --match-test 'test_Rbts'
  • Foundry tests pass (yarn foundry:test)
  • Contract size gate passes (yarn workspace @rateloop/foundry check:sizes)
  • Lint passes (yarn next:lint)
  • Type check passes (yarn next:check-types)
  • Base Sepolia readiness passes (yarn base-sepolia:check) when staging deployment/env wiring changed
  • Base mainnet readiness passes (yarn base-mainnet:check) when production deployment/env wiring changed
  • Node/workspace tests pass for changed packages (yarn test:ts or focused node scripts/run-node-tests.mjs ...)
  • E2E smoke checked when user-visible app flows changed (yarn e2e:ci:app or focused Playwright spec)
  • Tested locally with yarn start

Security

  • This PR does not disclose a private vulnerability. If it fixes a sensitive issue, coordinate disclosure via hawigxyz@proton.me.

Related Issues

Closes #

Open in Web View Automation 

Co-authored-by: David Hawig <Noc2@users.noreply.github.com>
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
rate-loop-nextjs Ready Ready Preview, Comment Jul 2, 2026 11:19am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant