feat(tarball): implement new EntryFilesAnalyser API#379
Merged
Conversation
🦋 Changeset detectedLatest commit: 72834db The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b593c44 to
b516bf9
Compare
b516bf9 to
070176f
Compare
c90cb77 to
00fabfc
Compare
5d63331 to
2112de1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the new EntryFilesAnalyser API and refactors the tarball scanning workflow. Key changes include:
- Integration of the EntryFilesAnalyser API in the SourceCodeScanner class.
- Introduction of a new NpmTarball class and modifications in tarball extraction and scanning.
- Updates across test files and documentation to support these API changes.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workspaces/tarball/test/fixtures/scanPackage/entryfiles/src/index.js | Uses CommonJS require with an imported ESM module, which may cause module system inconsistency. |
| workspaces/tarball/test/fixtures/scanPackage/entryfiles/src/foo.js | Exports using ES module syntax while being required from a CommonJS module. |
| workspaces/tarball/test/SourceCodeScanner.spec.ts | Contains a minor spelling issue in a test description. |
| workspaces/tarball/src/tarball.ts | Refactored to use the new NpmTarball class and updated dependency extraction. |
| workspaces/tarball/src/class/SourceCodeScanner.class.ts | Updated to leverage the new EntryFilesAnalyser API for processing manifest entry files. |
| workspaces/tarball/src/class/NpmTarball.class.ts | New file implementing tarball scanning logic in line with the updated API. |
| workspaces/scanner/src/depWalker.ts | Adjusted to use the TempDirectory class and updated scanDirOrArchiveEx call. |
PierreDemailly
approved these changes
Jun 18, 2025
01802eb to
72834db
Compare
72834db to
a0d16ef
Compare
PierreDemailly
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.