Feat/#380 refacto manifestmanager#385
Closed
davy-dev wants to merge 10 commits into
Closed
Conversation
|
fraxken
reviewed
May 25, 2025
fraxken
reviewed
May 25, 2025
…ise à jour des tests associés
… mise à jour du constructeur pour accepter des options
fraxken
requested changes
May 25, 2025
…addition of the assert in the constructor; consequently, the related test tied to the previous implementation has also been removed.
davy-dev
force-pushed
the
feat/#380-refacto-manifestmanager
branch
from
5cf8d25 to
d3c92ca
Compare
fraxken
requested changes
May 26, 2025
…stead of checking if it ends with "package.json"`**
davy-dev
force-pushed
the
feat/#380-refacto-manifestmanager
branch
from
123c2e5 to
6cc0867
Compare
fraxken
reviewed
Jun 1, 2025
Member
fraxken
left a comment
fraxken
left a comment
There was a problem hiding this comment.
Can you also add the changeset?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cette PR inclut les changements suivants sur le module
ManifestManager:manifestLocationet mise à jour du constructeur pour intégrer cette nouvelle propriété.manifestLocationafin d’assurer son bon fonctionnement.