feat(tarball): detect and flag with hasExternalCapacity when native f…

.changeset/cuddly-kids-shake.md

@@ -0,0 +1,5 @@
+---
+"@nodesecure/tarball": minor
+---
+
+(Tarball) detect and flag with hasExternalCapacity when native fetch is used

workspaces/tarball/package.json

@@ -31,7 +31,7 @@
   "dependencies": {
     "@nodesecure/conformance": "^1.0.0",
     "@nodesecure/fs-walk": "^2.0.0",
-    "@nodesecure/js-x-ray": "^8.1.0",
+    "@nodesecure/js-x-ray": "^8.2.0",
     "@nodesecure/mama": "^1.1.0",
     "@nodesecure/npm-types": "^1.2.0",
     "@nodesecure/utils": "^2.1.0",

workspaces/tarball/src/sast/file.ts

@@ -23,6 +23,9 @@ export interface scanFileReport {
   tryDependencies: string[];
   dependencies: string[];
   filesDependencies: string[];
+  filesFlags: {
+    hasExternalCapacity: boolean;
+  };
 }
 
 export async function scanFile(
@@ -53,7 +56,10 @@ export async function scanFile(
       isMinified: result.isMinified,
       tryDependencies,
       dependencies: packages,
-      filesDependencies: files
+      filesDependencies: files,
+      filesFlags: {
+        hasExternalCapacity: result.flags.has("fetch")
+      }
     };
   }
 
@@ -63,7 +69,10 @@ export async function scanFile(
     isMinified: false,
     tryDependencies: [],
     dependencies: [],
-    filesDependencies: []
+    filesDependencies: [],
+    filesFlags: {
+      hasExternalCapacity: false
+    }
   };
 }
 

workspaces/tarball/src/tarball.ts

@@ -130,6 +130,7 @@ export async function scanDirOrArchive(
   const filesDependencies = [...new Set(scannedFiles.flatMap((row) => row.filesDependencies))];
   const tryDependencies = new Set(scannedFiles.flatMap((row) => row.tryDependencies));
   const minifiedFiles = scannedFiles.filter((row) => row.isMinified).flatMap((row) => row.file);
+  const hasExternalCapacity = scannedFiles.some((row) => row.filesFlags.hasExternalCapacity);
 
   const {
     nodeDependencies,
@@ -156,6 +157,7 @@ export async function scanDirOrArchive(
 
   ref.flags.push(...booleanToFlags({
     ...flags,
+    hasExternalCapacity: hasExternalCapacity || flags.hasExternalCapacity,
     hasNoLicense: spdx.uniqueLicenseIds.length === 0,
     hasMultipleLicenses: spdx.uniqueLicenseIds.length > 1,
     hasMinifiedCode: minifiedFiles.length > 0,

workspaces/tarball/test/fixtures/scanJavascriptFile/fetch.js

@@ -0,0 +1,3 @@
+const apiService = async (url) =>  fetch(url);
+
+export default apiService;

workspaces/tarball/test/sast/scanFile.spec.ts

@@ -19,7 +19,10 @@ test("scanFile (fixture one.js)", async() => {
     isMinified: false,
     tryDependencies: [],
     dependencies: ["http", "mocha"],
-    filesDependencies: ["src\\foo.js", "home\\marco.js"].map((location) => location.replaceAll("\\", path.sep))
+    filesDependencies: ["src\\foo.js", "home\\marco.js"].map((location) => location.replaceAll("\\", path.sep)),
+    filesFlags: {
+      hasExternalCapacity: false
+    }
   });
 });
 
@@ -31,7 +34,10 @@ test("scanFile (fixture two.min.js)", async() => {
     isMinified: true,
     tryDependencies: ["http"],
     dependencies: ["http", "fs"],
-    filesDependencies: []
+    filesDependencies: [],
+    filesFlags: {
+      hasExternalCapacity: false
+    }
   });
 });
 
@@ -43,7 +49,10 @@ test("scanFile (fixture onelineStmt.min.js)", async() => {
     isMinified: false,
     tryDependencies: [],
     dependencies: [],
-    filesDependencies: ["foobar.js"]
+    filesDependencies: ["foobar.js"],
+    filesFlags: {
+      hasExternalCapacity: false
+    }
   });
 });
 
@@ -63,6 +72,24 @@ test("scanFile (fixture parsingError.js)", async() => {
     isMinified: false,
     tryDependencies: [],
     dependencies: [],
-    filesDependencies: []
+    filesDependencies: [],
+    filesFlags: {
+      hasExternalCapacity: false
+    }
+  });
+});
+
+test("scanFile (fixture fetch.js)", async() => {
+  const result = await scanFile(kFixturePath, "fetch.js", "yolo");
+  assert.deepEqual(result, {
+    file: "fetch.js",
+    warnings: [],
+    isMinified: false,
+    tryDependencies: [],
+    dependencies: [],
+    filesDependencies: [],
+    filesFlags: {
+      hasExternalCapacity: true
+    }
   });
 });