feat(mama): add LocatedManifestManager type and isLocated() type guard#420
feat(mama): add LocatedManifestManager type and isLocated() type guard#420intincrab wants to merge 2 commits into
Conversation
…d for ManifestManager
|
|
Ideally we should use tsd to properly assert types, this can be another later contribution/PR. We have examples in the RC workspace: scanner/workspaces/rc/test/types/index.test-d.ts Lines 2 to 12 in 97a36b5 scanner/workspaces/rc/package.json Line 15 in 97a36b5 |
|
And if you can push the changeset, thanks :) |
|
@fraxken based on the RC workspace example, I'm planning to create a type test file that would:
Is this the approach you had in mind for the type tests? |
Yes seems good |
closes #418
Changes:
LocatedManifestManagertype andisLocatedstatic method.