feat(mama): implement LocatedManifestManager type#424
Merged
PierreDemailly merged 9 commits intoJun 9, 2025
Conversation
🦋 Changeset detectedLatest commit: 286068b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PierreDemailly
changed the title
Member
|
Implem and tests lgtm |
Contributor
Author
|
@PierreDemailly I’ve added it, but it might not be correct, please have a look. Also, I’ve never added a changeset before, so it might be wrong? |
Member
|
The changeset is very good 👍 Just changes patch for minor, we're adding a feature here, not fixing a bug |
fraxken
approved these changes
Jun 9, 2025
PierreDemailly
approved these changes
Jun 9, 2025
Member
|
@all-contributors please add @intincrab for code |
Merged
Contributor
|
I've put up a pull request to add @intincrab! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #418
Changes
LocatedManifestManagertype to represent manifest instances with a locationisLocated()static type guard method for runtime type checkingtsdtsdas a dev dependency for type testing