use goembed to bundle fonts into the output binary#44
Open
robbyt wants to merge 1 commit intoNomadcxx:masterfrom
Open
use goembed to bundle fonts into the output binary#44robbyt wants to merge 1 commit intoNomadcxx:masterfrom
robbyt wants to merge 1 commit intoNomadcxx:masterfrom
Conversation
Owner
|
Bundling fonts would definitely solve some headaches with external font files. The embed setup looks good, but you are right since nothing is using assets.Fonts yet, would need to know your plan to integrate. Just want to see the complete picture of how font loading will work with the embedded files. -cheers RAM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new file that allows loading fonts at runtime directly from go instead of loading external files from a local file path.
It's currently not being used, but I will send a follow-up PR if you're interested to supplement the font loading system to try loading from the goembed fs before loading from disk.