ci: add Slack notifications to release workflow#240
Merged
hedgar2017 merged 17 commits intomainfrom Feb 27, 2026
Merged
Conversation
Split the monolithic prepare-release job into three environment-gated stages so elevated permissions are only granted to the final publish job, which requires manual approval. This v2 workflow runs in dry-run mode for validation before replacing the original release.yaml.
…release-v2 - Guard platform-toggle block with event_name check so inputs are only read on workflow_dispatch, preventing an empty build matrix on pull_request events. - Replace find|while subshell loop with sha256sum --check so a failed checksum actually fails the step.
PR ref names (e.g. `237/merge`) contain a slash which breaks the binary mv in build-rust. Use `pr<number>` instead for pull_request events.
Only use github.ref_name when ref_type is 'tag'; otherwise fall back to inputs.prerelease_suffix or 'notag'. This avoids slashes in paths from any non-tag ref (PRs, branches) without event-specific guards.
The review job was skipped on PR builds because get-previous-release (a transitive dependency via prepare) was skipped. GitHub Actions propagates skipped status through the needs chain unless overridden. Add !cancelled() + result check so review runs whenever prepare succeeds.
Replace the temporary unconditional pull_request trigger with a proper label-gated mechanism matching the pattern used by integration-tests and coverage workflows: - Add label-check job gating on `ci:release` label (blocks forks) - Run get-previous-release and changelog builder for PRs so dry-run output is realistic - Handle pull_request event in release name identification to avoid stripping `refs/pull/*/merge` as a tag - Skip the `release` environment approval gate for PR dry-runs - Remove obsolete TODO comment about temporary trigger
The previous pin (v2, SHA 27d65e1) internally used actions/cache/restore@v4 and actions/cache/save@v4 (unpinned tags), which violates the org's SHA-pinning policy. v2.23.0 pins its cache dependencies to full SHAs.
Delete release-v2.yaml — its 3-stage architecture (prepare/review/publish), per-job permissions, SHA256 checksums, and bundle/review gate are now in release.yaml alongside the production publish steps (attestation, softprops, deploy-docs, check-install-script). Remove the `always()` + `skipped` conditionals by making get-previous-release always run (~10s read-only gh call) and dropping it from prepare's needs (only publish consumes its output).
- Remove unused `tarball_name` output from prepare job - Make `get-previous-release` resilient to fresh repos with no releases - Add `permissions: contents: read` to `check-install-script` job - Add checksum file count validation before `sha256sum --check` - Clarify macOS universal binary condition with explicit trigger paths - Add `|| github.sha` fallback to `target_commitish` for tag releases - Trim `deploy-docs` permissions to only `contents: write`
- Remove dead code: unused `id: bundle` and `tarball_name` step output
- Add explicit `if` on publish job to tolerate get-previous-release failure
- Fix double ${{ }} evaluation in review job condition
- Increase artifact retention from 2 to 5 days for manual approval window
- Add `opened` to PR event types for pre-labeled PRs
- Enforce exact binary count (4) for tag releases to catch partial builds
Add "Review requested" and "Deployment starting" Slack notifications to the release pipeline, matching the pattern used in edr. A new notify-deploy job fires before the solx-release environment gate, and a step inside publish fires after approval. Both use continue-on-error: true so Slack outages never block releases. PR dry-runs skip notifications entirely.
Temporary step in the review job that sends a test Slack message during PR dry-runs to verify webhook integration. Clearly marked as [TEST] and must be removed before merging.
No need to wait for the full build pipeline — the test job now runs as a standalone job gated only on label-check.
The webhook integration has been verified; remove the test-only test-slack-notification job added for PR dry-run testing.
There was a problem hiding this comment.
Pull request overview
Adds Slack notifications to the release workflow to improve visibility around the manual environment approval gate for solx-release.
Changes:
- Introduces a
notify-deployjob to send a “Review requested” Slack message afterreviewcompletes and before the environment gate. - Adds a “Deployment starting” Slack notification as the first step in
publish(after environment approval). - Updates
publishjob dependencies to include the new notification job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Job-level continue-on-error shows a red job in the UI even when the failure is intentionally tolerated. Step-level keeps the job green while still never blocking the release pipeline.
hedgar2017
force-pushed
the
release-v2-workflow
branch
from
4c9c655 to
350c5df
Compare
hedgar2017
approved these changes
Feb 27, 2026
Contributor
hedgar2017
left a comment
hedgar2017
left a comment
There was a problem hiding this comment.
Looks good. Clean, minimal change — SHA-pinned action, step-level continue-on-error, correct dependency chain, PR dry-runs properly excluded. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notify-deployjob that sends a "Review requested" Slack message after the review stage passes, before thesolx-releaseenvironment approval gatepublish, firing after environment approvalcontinue-on-error: trueso Slack outages never block releasesslackapi/slack-github-action@v2.1.1), pinning, and secret (PUBLISHING_NOTIFICATIONS_SLACK_WEBHOOK_URL) as edrTest plan
workflow_dispatchpre-release that both real notifications arrive