Fail test if error log detected #1415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hasan6979
force-pushed
the
LLT-5433_fail_on_error_logs
branch
from
ab3549a to
355b947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This change was made to avoid having a lot of failed tests due to "ERROR" in logs. Some "ERROR" are acceptable, others aren't. This can cause a bug to fall through.
Solution
Enable failing test if log in ERROR is reported.
P.S. Next step of it would come if there are any failures due to ERROR logs, investigate them if logs need to be refined or error log needs more love.
☑️ Definition of Done checklist