Fix UAPI error tracker for backwards compatibility #1614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPukenis
force-pushed
the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
from
d78d098 to
a2acc14
Compare
LukasPukenis
force-pushed
the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
from
a2acc14 to
ba101a0
Compare
LukasPukenis
force-pushed
the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
from
ba101a0 to
12bd0df
Compare
LukasPukenis
force-pushed
the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
from
12bd0df to
bbf51a2
Compare
LukasPukenis
force-pushed
the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
from
bbf51a2 to
dd531ce
Compare
LukasPukenis
force-pushed
the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
from
dd531ce to
97286bc
Compare
LukasPukenis
force-pushed
the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
from
97286bc to
121e964
Compare
LukasPukenis
changed the title
Recent UAPI error tracker implementation removed the check if interface is present when considering critical error event. This makes the behavior not backwards compatible with the implementation which was present for the last 2 years. Without the check there's possibility to emit critical events with fewer conditions and can have real life consequences, so better play it safe. Signed-off-by: Lukas Pukenis <lukas.pukenis@nordsec.com>
LukasPukenis
force-pushed
the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
from
121e964 to
db615f1
Compare
3 tasks
Collaborator
Author
|
Superseded by: #1618 |
LukasPukenis
deleted the
lukasp/restore_interface_gone_check_in_uapi_error_handler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits
☑️ Definition of Done checklist