Llt 6812 move libfirewall dependent tests to gitlab

[stalowyjez]

Problem

telio-firewall tests which depend on libfirewall.so should be moved to gitlab

Solution

Make them integration tests and then run all of the integration tests on gitlab

☑️ Definition of Done checklist

• Commit history is clean (requirements)
• README.md is updated
• Functionality is covered by unit or integration tests

[jjanowsk]

How about moving firewall tests to the separate test target. You can do it by adding:

name = "firewall_tests"
path = "tests/integration_tests.rs"
test = false

to the Cargo.toml. This way you can run only those tests separately by running cargo test --test firewall_tests

This way if we want to have other integration tests still run here we can. (E.g. dns integration tests were the victim of current approach)

I have not tested this on telio-firewall so maybe there are some caveats but in theory it should work.

[stalowyjez]

@jjanowsk Hmm, I considered that, but in the end it seemed that making the split that unit tests run on github while crate/integration test run on gitlab it kinda cleaner than making and exception for libfirewall - but if you think that would be much better, I can limit it to firewall tests only

[jjanowsk]

Personally I prefer separate target just for firewall tests. You can ask someone else for the 3rd opinion :)

[mathiaspeters]

I also like the idea of a separate target. It will be slightly more complex, but I think it makes sense that since this is an open source repo we should keep as much open as we can

[stalowyjez]

@jjanowsk @mathiaspeters reduced the scope of the tests run on gitlab to firewall ones

[LukasPukenis]

+1

The PR looks fine to me but if I understand correctly, the current approach requires libtelio-build to be aware of firewall_integration_tests name in order to run it.

A more generic solution could be to use a feature so we could gatekeep multiple tests(if needed) to run only in CI with a single feature.

Though, given that this is currently only for libfirewall tests there probably is not much difference at the moment.