[LLT-6924] Read .env for recorded git sha in scheduled runs #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekoliinyk
requested review from
a team,
Jauler,
LukasPukenis,
asledzinskiy,
jjanowsk,
mathiaspeters,
matislovas and
tomaszklak
as code owners
Contributor
|
+1 |
jjanowsk
reviewed
Dec 19, 2025
olekoliinyk
force-pushed
the
LLT-6924_checkout_to_recorded_sha_in_read_dotenv
branch
from
a85b9ba to
cf6ebfb
Compare
jjanowsk
approved these changes
Dec 19, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
…ded_sha_in_read_dotenv [LLT-6924] Read .env for recorded git sha in scheduled runs
olekoliinyk
deleted the
LLT-6924_checkout_to_recorded_sha_in_read_dotenv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have a race condition in scheduled github pipelines (which triggers gitlab pipelines).
In our
trigger-gitlab-pipelineingitlab_schedule.ymljob we taketriggered-reffromread_dotenv.ymlfile. It first checkouts the code to get this.envfile. It should checkout the correct sha (recorded_shafromprepare-shajob) instead of the latest main.Solution
read_dotenv.ymlto checkout libtelio torecorded_sharecorded_shais not provided checkout to current branch☑️ Definition of Done checklist