feat: current toc item and page information as a stream#77
Draft
feat: current toc item and page information as a stream#77
Conversation
m-abs
changed the title
…ant it to flatten children in the TOC
… into feat/current-toc * 'feat/current-toc' of github.com:Notalib/flutter_readium: fix(android): List<Link>.flatten also flattened alternates, we only want it to flatten children in the TOC findCssSelectorForLocator sometimes found the wrong cssSelector
…idn't work Progression from the locator and progressing in the elements from the content service doesn't match, so we found the wrong cssSelector. Switching back to using the readium.findFirstVisibleLocator() instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a better way to know the current toc item and page information from the plugin.
From LYT4 we have inherited a problematic way of handling current toc and information about current page. These are added to the current locator's fragments where they don't belong.
This removes a lot of the inherited javascript from LYT4.