Fix: constraint-validator false positive on valid YAML frontmatter#53
Open
brookewhatnall wants to merge 1 commit into
Open
Conversation
The skill_structure constraint check was passing evolved_body (markdown body with frontmatter stripped) instead of evolved_full (complete file). Since the validator checks for YAML frontmatter markers, it always failed on valid skills — a false positive documented in the README. Now checks evolved_full with baseline_text=skill['raw'] for consistency. Fixes the bug reported in README: 'The constraint validator has a false positive bug on valid YAML.'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skill_structure constraint check was passing evolved_body (markdown body with frontmatter stripped) instead of evolved_full (complete file). Since the validator checks for YAML frontmatter markers, it always failed on valid skills — a false positive documented in the README.
Now checks evolved_full with baseline_text=skill['raw'] for consistency.
Fixes the bug reported in README: 'The constraint validator has a false positive bug on valid YAML.'