PMC test improvements; remove regions, use a dedicated fixtures folder, improve apex migration skill#7502
Open
nkolev92 wants to merge 1 commit into
Open
PMC test improvements; remove regions, use a dedicated fixtures folder, improve apex migration skill#7502nkolev92 wants to merge 1 commit into
nkolev92 wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Nigusu-Allehu
approved these changes
Jun 23, 2026
jebriede
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
This is a test-only follow-up change; no issue required.
Description
Addresses post-merge review feedback from #7467 (PMC
Find-Package/Get-Packagetest migration):#regionblocks fromFindPackageCommandTests.csandGetPackageCommandTests.cs(Coding Guideline 17).CmdletRunspaceFixtureandTestPSHostintoFixtures/CmdletRunspaceFixture.csas shared internal classes (registers bothFind-PackageandGet-Package), eliminating duplication across the two test files. Cleaned up now-unused usings.GetPackageTestCase.cs(falsy->false).apex-migrationskill to reference the repo-widedocs/coding-guidelines.mdinstead of restating common rules; the Style rules section now only lists migration-specific conventions that supplement the common guidelines.Verified:
NuGetConsole.Host.PowerShell.Testbuilds with 0 warnings/0 errors and all 23 Find/Get cmdlet unit tests pass.PR Checklist