Use hardcoded psmdcp name to fix deterministic pack file-handle leak#7503
Merged
Conversation
…e-handle leak Fixes NuGet/Home#14959 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
omajid
approved these changes
Jun 23, 2026
jebriede
previously approved these changes
Jun 23, 2026
jebriede
left a comment
jebriede
left a comment
Contributor
There was a problem hiding this comment.
Approving with suggestion.
zivkan
previously approved these changes
Jun 24, 2026
akoeplinger
reviewed
Jun 24, 2026
zivkan
approved these changes
Jun 25, 2026
akoeplinger
approved these changes
Jun 25, 2026
nkolev92
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14959
Description
Deterministic pack leaks a file handle:
PackageBuilder.CalcPsmdcpName()callsfile.GetStream()for every file in the package and passes it toReadAllBytes(), which only disposes the intermediateMemoryStream— the source stream returned byGetStream()(aFile.OpenRead(...)for physical files) is never disposed.Per OPC standards, the actual name just needs to be deterministic and it does not have to be per package unique, so using a hardcoded name is just fine.
PR Checklist