Conversation
…internal/logger The external logger package is being deprecated. Replace it with a thin internal wrapper around go.uber.org/zap that provides the same API. - Create internal/logger package wrapping zap directly (~55 lines) - Logs go to stderr instead of stdout to avoid corrupting piped CLI output - Use zap.NewDevelopmentConfig() to preserve full zap dev defaults - Remove no-op OTel tracer calls from internal/auth/login.go - Update ldflags in Makefile and .goreleaser.yaml - Remove ~30 transitive dependencies (AWS SDK, OTel, Lambda, etc.)
The chat command is deprecated. Remove the command, the entire internal/chat package, all README references, and the gorilla/websocket dependency which was only used by chat.
Member
|
Lgtm just fix the lint |
dnjg
previously approved these changes
Mar 25, 2026
…rmatting Fix errcheck violations by handling errors from os.MkdirAll and os.WriteFile. Replace WriteString(fmt.Sprintf(...)) with fmt.Fprintf for staticcheck QF1012. Fix gofmt alignment in generated command files.
Add logger.Close() helper to handle Sync() error cleanly and replace all defer logger.L(ctx).Sync() calls with defer logger.Close(ctx). Fix gofmt import ordering across cmd and internal packages. Fix unchecked buf.ReadFrom in logger test.
tim-thacker-nullify
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/nullify-platform/loggerwith a newinternal/loggerpackage that wrapsgo.uber.org/zapdirectly. Logs now go to stderr instead of stdout to avoid corrupting piped CLI output. Removes ~30 transitive dependencies (AWS SDK, OTel, Lambda, SSM, etc.)nullify chatcommand, the entireinternal/chatpackage, all README references, and thegorilla/websocketdependencyTest plan
go build ./...passesgo test ./...— 126 tests pass across 16 packagesmake build && ./bin/cli version— version stamping works via ldflags./bin/cli status— verified against live instancegrep -r "nullify-platform/logger" .— zero stale referencesgrep -ri "\bchat\b"— no residual chat command referencesgo mod why github.com/gorilla/websocket— confirms dependency fully removed