Open
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 6 6
Lines 1414 1414
=======================================
Hits 1387 1387
Misses 27 27 ☔ View full report in Codecov by Sentry. |
SKopecz
approved these changes
Jul 18, 2024
Collaborator
SKopecz
left a comment
SKopecz
left a comment
There was a problem hiding this comment.
Okay, there is no difference. I'd leave it up to you if we want to merge this or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #101 (comment)
However, I do not think that the linear solvers for sparse matrices change the sparse matrix as you fear. But we can check how it looks like with the change you have proposed. If the performance is not affected significantly, we can stay on the safe side.