Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
- Coverage 97.92% 97.76% -0.17%
==========================================
Files 7 8 +1
Lines 1641 2009 +368
==========================================
+ Hits 1607 1964 +357
- Misses 34 45 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This should be ready for review 🙂. Some additional comments:
|
|
The Downgrade job might be fixed by SciML/SimpleNonlinearSolve.jl#168 once this is released. |
|
JuliaRegistries/General#127812 has been merged. Could you please try if this fixes Downgrade by rerunning this job (I don't have the rights)? |
JoshuaLampert
left a comment
There was a problem hiding this comment.
This is really nice! Also cool to see that we can reproduce the order with Double64 also for the high-order schemes. I only have a few minor comments.
ranocha
left a comment
There was a problem hiding this comment.
Thanks a lot! I just have minor suggestions. This is ready to be merged when Joshua's comments are resolved as well.
|
In the original paper the MPDeC schemes depend on two parameters, |
|
The only failing test is CI / finish (pull_request). Any idea how to fix this? |
We also see this issue in other repos. Coveralls seems to be broken at the moment. I think we can just ignore it here. |
|
Then we're ready to merge, right? Do we keep the version number "0.2.10-DEV"? |
Implementation of the MPDeC methods
This closes #42.