Skip to content

Update alg_cache to take verbose argument for compatibility with new OrdinaryDiffEqCore.__init#178

Merged
ranocha merged 21 commits intoNumericalMathematics:mainfrom
jClugstor:alg_cache_verbose
Feb 5, 2026
Merged

Update alg_cache to take verbose argument for compatibility with new OrdinaryDiffEqCore.__init#178
ranocha merged 21 commits intoNumericalMathematics:mainfrom
jClugstor:alg_cache_verbose

Conversation

@jClugstor
Copy link
Contributor

@jClugstor jClugstor commented Nov 10, 2025

An upcoming PR (SciML/OrdinaryDiffEq.jl#2895) will change the number of arguments that alg_cache expects in OrdinaryDiffEqCore.__init. This PR isn't needed yet, but will be needed in order to compatible with OrdinaryDiffEqCore when that PR merges.

Closes #185.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls
Copy link

coveralls commented Jan 29, 2026

Pull Request Test Coverage Report for Build 21682043306

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.493%

Totals Coverage Status
Change from base Build 21564816929: 0.0%
Covered Lines: 1789
Relevant Lines: 1835

💛 - Coveralls

@JoshuaLampert
Copy link
Member

Thanks, @jClugstor. Would you mind fixing the formatting issue and ideally look at the failing Downgrade test? Probably some compat bounds need to be bumped. Otherwise this LGTM.

@jClugstor jClugstor marked this pull request as ready for review January 29, 2026 16:43
@JoshuaLampert
Copy link
Member

Thanks! Regarding the formatting: I guess you used JuliaFormatter.jl v2? Could you please use v1.0.60 because this is the version we currently use in CI.

@jClugstor
Copy link
Contributor Author

I believe that the SciMLBase lower compat bound just needed to be bumped to match the lower compat bound in OrdinaryDiffEq. I did that and then formatted so hopefully it's all good now.

@jClugstor
Copy link
Contributor Author

Oh yes I'll reformat.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Jan 29, 2026

Looks like there are some formatting changes that survived. Could you please revert every formatting change not related to the verbose argument? And it seems Downgrade is still not happy.

@JoshuaLampert
Copy link
Member

The formatting and Downgrade should be fixed now. CI is currently failing because of some issues with OrdinaryDiffEq.jl introduced lately. Once this is fixed, this LGTM. Thanks again, @jClugstor.

@JoshuaLampert JoshuaLampert requested a review from ranocha February 4, 2026 20:04
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranocha ranocha merged commit 750302a into NumericalMathematics:main Feb 5, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants