[11.0][IMP] base: Added model_name value insertion in ir.cron migration #5470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Odoo v11.0, ir.cron possesses delegated fields from ir.actions.server related to models, model_id and model_name. The migration script currently assigns the model_id value, but not the model_name. This is problematic, as from 11.0's version of base, the model_name from ir.servers.action is a stored field, and since the server action record is inserted directly as a row in the PSQL table, the model_name field is initially set to null, and not recomputed within Odoo to match the model_id's model field. As such, alongside the server action row insertion, we also set model_name to its intended value (model from the ir_model table).
hbrunn
approved these changes
Dec 12, 2025
fcayre
approved these changes
Dec 12, 2025
Member
|
/ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
pedrobaeza
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Odoo v11.0,
ir.cronpossesses delegated fields fromir.actions.serverrelated to models,model_idandmodel_name.The migration script currently assigns the
model_idvalue, but not themodel_name.This is problematic, as from 11.0's version of base, the
model_namefromir.servers.actionis a stored field, and since the server action record is inserted directly as a row in the PSQL table, themodel_namefield is initially set to null, and not recomputed within Odoo to match themodel_id'smodelfield.This can cause issues in later versions of Odoo, such as Odoo 16.0, where the
model_namefield is used within therunmethod ofir.actions.serverin thebasemodule.As such, alongside the server action row insertion, we also set
model_nameto its intended value (modelfrom their_modeltable).