Skip to content

[18.0][IMP] partner_event: avoid matching partner_id as attendee when email…#509

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
invitu:18.0-imp_partner_event_attendee_no_email
Jul 4, 2026
Merged

[18.0][IMP] partner_event: avoid matching partner_id as attendee when email…#509
OCA-git-bot merged 1 commit into
OCA:18.0from
invitu:18.0-imp_partner_event_attendee_no_email

Conversation

@cvinh

@cvinh cvinh commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

… is shared

Steps to reproduce :

  1. Install partner_event
  2. Create an event with "Create Partners in registration" checked
  3. Create a partner with an email address
  4. Create a registration for that event with:
    • partner_id = the partner above
    • name = "Child Attendee" (a different person)
    • email = same email as partner_id (e.g. fallback when attendee has no email)
  5. Check attendee_partner_id on the registration

Expected: attendee_partner_id is created with empty email
Got: attendee_partner_id = partner_id

@cvinh cvinh marked this pull request as ready for review June 29, 2026 02:17
@cvinh cvinh force-pushed the 18.0-imp_partner_event_attendee_no_email branch 3 times, most recently from 65e9df8 to a5331c6 Compare June 29, 2026 04:35
@cvinh cvinh marked this pull request as draft June 29, 2026 04:39
@cvinh cvinh force-pushed the 18.0-imp_partner_event_attendee_no_email branch 2 times, most recently from 211a263 to a8d6bf9 Compare June 29, 2026 05:15
@cvinh cvinh force-pushed the 18.0-imp_partner_event_attendee_no_email branch from a8d6bf9 to 9f28f38 Compare June 29, 2026 05:37
@cvinh cvinh marked this pull request as ready for review June 29, 2026 06:06
@pedrobaeza pedrobaeza added this to the 18.0 milestone Jun 29, 2026
BhaveshHeliconia
BhaveshHeliconia approved these changes Jun 30, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@OCA-git-bot

OCA-git-bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza

pedrobaeza commented Jul 4, 2026

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-509-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit da1345f into OCA:18.0 Jul 4, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 9d8b8e8. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza

pedrobaeza commented Jul 4, 2026

Copy link
Copy Markdown
Member

Please fw-port it to 19

@cvinh

cvinh commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Please fw-port it to 19

#521

@cvinh cvinh deleted the 18.0-imp_partner_event_attendee_no_email branch July 4, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes
+1 more reviewer
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:partner_event Module partner_event ready to merge series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cvinh @OCA-git-bot @pedrobaeza @BhaveshHeliconia