-
-
Notifications
You must be signed in to change notification settings - Fork 79
[15.0][IMP] github_connector_odoo: Remove uninstallable #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] github_connector_odoo: Remove uninstallable #130
Conversation
|
Please use proper commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message And why removing the module instead of marking it uninstallable? |
If the module is uninstallable and module version exist, we drop it The default for installable is True
eb18ee7 to
92a1368
Compare
|
@pedrobaeza There is no installable/uninstallable flag on odoo.module.version model afaik Commit message updated |
pedrobaeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK then
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza The merge process could not be finalized, because command |
|
Congratulations, your PR was merged at f57a30c. Thanks a lot for contributing to OCA. ❤️ |
The default for installable is True