Skip to content

Conversation

@hhgabelgaard
Copy link
Contributor

The default for installable is True

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 24, 2024
@pedrobaeza
Copy link
Member

Please use proper commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

And why removing the module instead of marking it uninstallable?

If the module is uninstallable and module version
exist, we drop it

The default for installable is True
@hhgabelgaard hhgabelgaard force-pushed the 15.0-unlink-uninstallable-modules-hhg branch from eb18ee7 to 92a1368 Compare November 24, 2024 15:14
@hhgabelgaard
Copy link
Contributor Author

@pedrobaeza There is no installable/uninstallable flag on odoo.module.version model afaik
And current operation is to only add odoo.module.version records if the addon is installable.
Like when the source is no longer present.
But we could add an installable flag. Or add 'active' field?

Commit message updated

@pedrobaeza pedrobaeza changed the title [IMP] Remove uninstallable module versions if exist [15.0][IMP] github_connector_odoo: Remove uninstallable Nov 25, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then

@github-actions
Copy link

github-actions bot commented Jun 8, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 8, 2025
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-130-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 15.0-ocabot-merge-pr-130-by-pedrobaeza-bump-patch:15.0 failed with output:

To https://github.com/OCA/interface-github
 ! [rejected]        15.0-ocabot-merge-pr-130-by-pedrobaeza-bump-patch -> 15.0 (fetch first)
error: failed to push some refs to 'https://github.com/OCA/interface-github'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot OCA-git-bot merged commit ca99b3a into OCA:15.0 Jun 8, 2025
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f57a30c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants