Skip to content

Conversation

@mathben
Copy link

@mathben mathben commented Oct 15, 2025

  • copying project_purchase_link and rename purchase to sale

@mathben mathben changed the title [ADD] project_sale_link [18.0][ADD] project_sale_link Oct 15, 2025
@mathben mathben force-pushed the 18.0-project_sale_link branch 3 times, most recently from 5fc10a4 to 433c0b2 Compare October 15, 2025 04:08
- copying project_purchase_link and rename purchase to sale
@mathben mathben force-pushed the 18.0-project_sale_link branch 4 times, most recently from 0d27c75 to 3310ff0 Compare October 15, 2025 09:10
@mathben mathben changed the title [18.0][ADD] project_sale_link [18.0][WIP][ADD] project_sale_link Oct 15, 2025
@mathben mathben force-pushed the 18.0-project_sale_link branch 2 times, most recently from 4f2c2e7 to a5c3038 Compare October 17, 2025 05:54
@mathben mathben changed the title [18.0][WIP][ADD] project_sale_link [18.0][ADD] project_sale_link Oct 17, 2025
@mathben mathben force-pushed the 18.0-project_sale_link branch 3 times, most recently from d209d40 to 2ed9dcb Compare October 17, 2025 20:55
…ulation

- use move_out for sale
- count invoice use move_id_count
- count sale use price_subtotal_count
- detection analytic_distribution change add_where request
- improve test
@mathben mathben force-pushed the 18.0-project_sale_link branch from 2ed9dcb to a68adfc Compare October 17, 2025 20:57
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
LGTM
sucessfully tested on runboat

@mathben
Copy link
Author

mathben commented Dec 6, 2025

ping @carlos-lopez-tecnativa @pedrobaeza
Thanks you!

@pedrobaeza
Copy link
Member

Copy from where? Did the previous authors sign the OCA CLA? You should also respect the whole commit history, and rename it from the beginning with:

git filter-branch --tree-filter 'if [ -d <old_module_name> ]; then mv <old_module_name> <new_module_name>; fi' HEAD
git rebase origin/18.0

@mathben
Copy link
Author

mathben commented Dec 9, 2025

Copy from where?

This repository : https://github.com/OCA/project/tree/18.0/project_purchase_link

Did the previous authors sign the OCA CLA?

I didn't check : https://github.com/OCA/project/blob/18.0/project_purchase_link/readme/CONTRIBUTORS.md

You should also respect the whole commit history, and rename it from the beginning with

The history : https://github.com/OCA/project/commits/18.0/project_purchase_link
It's a little hard to copy, the history is already in this repository.
I run your command to test and nothing done (except recommit all history).
Thanks @pedrobaeza

@pedrobaeza
Copy link
Member

OK, then it's not a copy, but it's a "brother" module inspired from the other. Isn't this what sale_project do? In any case, it's OK to add it and just mention in the CREDITS.md file that this comes from project_purchase_link.

@leemannd
Copy link
Contributor

leemannd commented Dec 9, 2025

Hello, we formerly already had a similar module in 13.0 -> #940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants