Skip to content

[18.0][FIX] repair_order_group: keep groups only for draft duplicates#149

Open
Mohajiro wants to merge 2 commits into
OCA:18.0from
cetmix:18.0-t5252-repair_order_group-updates
Open

[18.0][FIX] repair_order_group: keep groups only for draft duplicates#149
Mohajiro wants to merge 2 commits into
OCA:18.0from
cetmix:18.0-t5252-repair_order_group-updates

Conversation

@Mohajiro

Copy link
Copy Markdown
Contributor

Duplicating grouped repairs after draft can unintentionally keep them tied to the original group, mixing operational flows and shared quotations. Restrict group propagation to draft repairs to match expected usage.

Task: 5252

@ivs-cetmix ivs-cetmix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@Aldeigja Aldeigja left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 5, 2026
@ivs-cetmix ivs-cetmix removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 7, 2026
@ivs-cetmix

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-149-by-ivs-cetmix-bump-patch, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@ivs-cetmix your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-149-by-ivs-cetmix-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Duplicating grouped repairs after draft can unintentionally keep them tied
to the original group, mixing operational flows and shared quotations.
Restrict group propagation to draft repairs to match expected usage.

Task: 5252
@tendil
tendil force-pushed the 18.0-t5252-repair_order_group-updates branch from dfd4143 to 84b6389 Compare July 8, 2026 07:39
@OCA-git-bot OCA-git-bot added series:18.0 mod:repair_order_group Module repair_order_group labels Jul 8, 2026
Keep repair groups copyable for draft repair duplications.

Task: 5252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants