[19.0][MIG] web_company_color: Migration to 19.0#3326
[19.0][MIG] web_company_color: Migration to 19.0#3326BhaveshHeliconia wants to merge 54 commits into
Conversation
|
What's the status on this ? I see it's been open for 3 months already. What's the blocking? |
|
@codeagencybe This PR is currently waiting for a reviewer. That’s the main blocker at the moment. |
Currently translated at 100.0% (9 of 9 strings) Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/zh_CN/
We need to disable the company unlinking test, as if not, when tested in integrated environments, it fails as there are records linked to the company, like the warehouse when `stock` module is installed.
If we change something with base.document.layout wizard, this will launch the colors computing even without changing the logo. This procedure will change the value of the colors if they were set by hand. This change forces the user to press a button to recompute the colors and avoid possible undesired changes. TT34902
Currently translated at 100.0% (10 of 10 strings) Translation: web-15.0/web-15.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_company_color/de/
See upstream commit: odoo/odoo@0bc24a7
Currently translated at 100.0% (10 of 10 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/de/
This functionality allows changing the color of the icons in the systray menu based on the Navbar Text Color.
Currently translated at 100.0% (17 of 17 strings) Translation: web-17.0/web-17.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_company_color/es/
Currently translated at 100.0% (17 of 17 strings) Translation: web-18.0/web-18.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_company_color/fr/
When used on mobile/tablet view, the buttons and texts in the navbar do not match the company colors.
709ef06 to
94959d9
Compare
|
Hello, |
|
@Linekio Thanks for the feedback. Could you please elaborate on what’s not working in dark mode? That will help me better understand and investigate the issue. |
|
Hello, |
|
@Linekio I’ve tested it in light mode and it’s working as expected. I haven’t tested it in dark mode, as Odoo doesn’t provide native dark mode support, and I’m not aware of any official OCA module for it. |
@pedrobaeza do we need to consider compatibility with third-party dark mode modules in this case? |
|
I think he's talking about https://github.com/OCA/web/tree/19.0/web_dark_mode |
Thanks, I’ll work on that. |
|
@Linekio I’ve reviewed the functionality of the module. It extracts colors from the uploaded company logo and applies them to the corresponding fields. This logic is independent of light or dark mode, as the module itself is not aware of any theme context. To support dark mode, we would need to introduce a dependency on a module like web_dark_mode and adapt the color extraction logic based on whether dark mode is enabled. |
|
Hi, what's the status of this? In my opinion, supporting dark mode would warrant a separate connector module in order to avoid any unwanted dependency chains. I think the right decision would be to merge this without dark mode support. |
| } | ||
| } | ||
| .o_menu_systray button, | ||
| .o_navbar_breadcrumbs, |
There was a problem hiding this comment.
In Odoo 19 the breadcrumbs element is now <div class="o_navbar_breadcrumbs d-contents">. Because of d-contents the div renders no box of its own, so applying color/background-color hover rules to .o_navbar_breadcrumbs directly is a no-op the breadcrumb text/links are already covered by the navbar text and link color rules. So I dropped it as dead CSS rather than keep a selector that no longer does anything.
.o_menu_systray button wasn't actually removed — I split it into its own dedicated rule lower in the template (.o_menu_systray button { color: ...; &:hover/&:focus { background-color: ... } }), keeping the exact same color and hover behavior. The diff just shows it leaving the old grouped selector.
20 participants
No description provided.