[19.0][MIG] web_filter_header_button: Migration to 19.0#3329
Open
BhaveshHeliconia wants to merge 11 commits into
Open
[19.0][MIG] web_filter_header_button: Migration to 19.0#3329BhaveshHeliconia wants to merge 11 commits into
BhaveshHeliconia wants to merge 11 commits into
Conversation
46 tasks
Member
|
/ocabot migration web_filter_header_button |
BhaveshHeliconia
force-pushed
the
19.0-mig-web_filter_header_button
branch
from
March 11, 2026 08:51
80c3990 to
03e854f
Compare
Now we can configure group filters to show up along the other filters so users can easily access those as well. TT49232
When there are too many buttons, they won't fit in the window and they will overlap with other ui elemnets. We can prevent it putting them in their own row. TT49431
In custom views, like the reconciliation one, that use the control panel we must prevent loading the FilterButton component. TT49664
…rrors referring self
BhaveshHeliconia
force-pushed
the
19.0-mig-web_filter_header_button
branch
from
July 16, 2026 05:04
03e854f to
d574b32
Compare
Contributor
Author
|
@chienandalu @CarlosRoca13 Could you please review this? Thanks! |
CarlosRoca13
approved these changes
Jul 21, 2026
CarlosRoca13
left a comment
Contributor
There was a problem hiding this comment.
Just a minor change
| > | ||
| <i | ||
| t-if="options.icon" | ||
| t-attf-class="fa {{options.icon}} {{name !== '' ? 'mr-1' : ''}}" |
Contributor
There was a problem hiding this comment.
Suggested change
| t-attf-class="fa {{options.icon}} {{name !== '' ? 'mr-1' : ''}}" | |
| t-attf-class="fa {{options.icon}} {{name !== '' ? 'me-1' : ''}}" |
BhaveshHeliconia
force-pushed
the
19.0-mig-web_filter_header_button
branch
from
July 21, 2026 05:47
d574b32 to
9a86b7d
Compare
CarlosRoca13
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.