Remove username from raw_user_meta_data

[jproberson]

PR Checklist

• - Unit and/or e2e tests for the changes that have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Refactoring (no functional changes)
• Documentation
• Other:

What is the new behavior?

Describe the new behaviour
If useful, provide screenshot or capture to highlight main changes

Does this PR introduce a DB Schema Change or Migration?

• Yes
• No

Git Issues

Closes #

What happens next?

Thank you for the contribution! We will review it ASAP.

If you need more immediate feedback you can reach out to us on Discord in the Community Platform development channel.

[cypress]

onearmy-community-platform    Run #8967

Run Properties:   Failed #8967  •  da4b8e840d: update integration tests, re-implement username length check

Project	onearmy-community-platform
Branch Review	feat/remove-raw_user_meta_data
Run status	Failed #8967
Run duration	11m 28s
Commit	da4b8e840d: update integration tests, re-implement username length check
Committer	Jacob Roberson
View all properties for this run ↗︎

---

Test results
Failures	23
Flaky	1
Pending	0
Skipped	0
Passing	69
View all changes introduced in this branch ↗︎

---

Tests for review

  profile.spec.ts • 5 failed tests • ci-chrome

View Output Video

Test		Artifacts
[Profile] > [By User] > [User directed to own profile]		Test Replay Screenshots Video
[Profile] > [By User] > [Contact form]		Test Replay Screenshots Video
[Profile] > [By User] > [Cannot see profile views or member history without premium tier]		Test Replay Screenshots Video
[Profile] > [Upgrade Badge Button] > [Should show Go PRO button when user does not have pro badge]		Test Replay Screenshots Video
[Profile] > [Upgrade Badge Button] > [Should not show Go PRO button when viewing another user profile]		Test Replay Screenshots Video

  settings.spec.ts • 7 failed tests • ci-chrome

View Output Video

Test		Artifacts
Notifications		Test Replay Screenshots Video
[Settings] > Can create member		Test Replay Screenshots Video
[Settings] > Can create space		Test Replay Screenshots Video
[Settings] > Cannot use a taken username		Test Replay Screenshots Video
[Settings] > Cannot use a username that is too short		Test Replay Screenshots Video
[Settings] > Can change username		Test Replay Screenshots Video
[Precious Plastic] > Can create impact for space		Test Replay Screenshots Video

  library/write.spec.ts • 1 failed test • ci-chrome

View Output Video

Test		Artifacts
[Library] > [Create a project] > [By Incomplete Profile User]		Test Replay Screenshots Video

  news/write.spec.ts • 1 failed test • ci-chrome

View Output Video

Test		Artifacts
[News.Write] > [Create a news item] > [Profile badge restricts visibility]		Test Replay Screenshots Video

  questions/discussions.spec.ts • 2 failed tests • ci-chrome

View Output Video

Test		Artifacts
[Questions.Discussions] > allows users to sort comments		Test Replay Screenshots Video
[Questions.Discussions] > allows authenticated users to contribute to discussions		Test Replay Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

  src/integration/profile.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
[By Premium Tier User] > [Displays other information]		Test Replay Screenshots Video

[benfurber]

@jproberson Can I get a description for this please to understand why this change is being proposed?

[mariojsnunes]

@benfurber currently we store the username on the auth.users object, it was essential for the firebase migration.
But it causes 2 issues:

• in case an account exists in multiple tenant, the username must be the same across them
• harder to change the username

It is also one more thing adding complexity now that we are also looking into creating accounts without profiles (in a first step, for the memberships flow)

This PR is to investigate if we can safely get rid of it, or there is some dependency.

[mariojsnunes]

@jproberson there are still some references to user_metadata

ensureProfile() is how we allow seamless login to each tenant if the user has already registered once.
Need an alternative to that, either:

• have a UI to prompt the user for a username
• create the profile without the username - need to see what are the edge cases here
• get the username from another tenant (via supabase admin rpc)

send-email edge function:

• fetch the profile via auth_id, or
• change the email message to not include the username

fetch a research item with updates - it's required due to collaborators being stored as a list of usernames:

• just make an additional query to the current user profile to get the username, or
• migrate the collaborators to use ids instead - might be worth doing eventually

search projects - to search by author:

• just make an additional query to the current user profile to get the username

[jproberson]

remade the branch to avoid some rather interesting conflicts. closing.
#4684