Feature/add is migration field to metadata endpoint - #761
Open
aryan-p03 wants to merge 10 commits into
Open
Conversation
… correct website version link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
is_migrationfield toGET /metadataendpoint (ticket here)website_versionlink forGET /metadataendpoint (ticket here)URIfor the search content updated Kafka event (ticket here)How to review
For tickets 1 and 2:
is_migrationset totrueat both series and version levelGET /metadatain publishing mode to seeis_migrationreturned and call in web mode to see it not returnedwebsite_versionlink returned is correct (contains the topic slug). If the dataset is not static then it return it without the topic slug.For ticket 3:
PUT /stateto transition to published, check the dataset-api logs and within thesearch_content_updatedlogData you should see theURIset including the topic slug.Note:
Technically legacy behaviour has been changed for
GET /metadatawithin publishing mode as URL rewriting has been enabled for thewebsite_versionlink. The change being that the host on thewebsite_versionlink when called within publishing mode will be the publishing host (previously this would have been the public host). This is not expected to cause any issues and does affect web mode.Who can review