feat(DIS-4350): add protective monitoring to dp-identity-api#254
Merged
Conversation
| var ( | ||
| GroupsUsersList *[]models.ListGroupUsersType | ||
| ) | ||
| authEntityData, ok := authorisation.AuthEntityDataFromContext(req.Context()) |
Contributor
There was a problem hiding this comment.
Not a sensitive read endpoint so not required.
| } | ||
|
|
||
| // ListUsersHandler lists the users in the user pool | ||
| func (api *API) ListUsersHandler(ctx context.Context, _ http.ResponseWriter, req *http.Request) (*models.SuccessResponse, *models.ErrorResponse) { |
Contributor
There was a problem hiding this comment.
Not a sensitive read endpoint so not required.
| @@ -0,0 +1,17 @@ | |||
| package models | |||
|
|
|||
| // Action represents the action that was performed on the policy | |||
Contributor
There was a problem hiding this comment.
It's not on a policy :)
Comment on lines
+6
to
+17
| // Outcome represents the outcome of the action | ||
| type Outcome string | ||
|
|
||
| const ( | ||
| ActionCreate Action = "CREATE" | ||
| ActionRead Action = "READ" | ||
| ActionUpdate Action = "UPDATE" | ||
| ActionDelete Action = "DELETE" | ||
|
|
||
| OutcomeSuccess Outcome = "success" | ||
| OutcomeFailure Outcome = "failure" | ||
| ) |
Contributor
There was a problem hiding this comment.
We might want to consider moving these to the logging library - probably not one for now though.
Contributor
Author
There was a problem hiding this comment.
Agreed, I've added this to the backlog - https://officefornationalstatistics.atlassian.net/browse/DIS-4871
lindenmckenzie
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added protetctive monitioring given authentication data to the necessary handlers
How to review
All handlers that are sensitive have protective monitoring
Who can review
!me