HYRAX-1965 - Removed transfer thread concurrency from DmrppArray#1279
HYRAX-1965 - Removed transfer thread concurrency from DmrppArray#1279dh-opendap merged 4 commits intomasterfrom
Conversation
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
I have a suggestion. I want to look at these 'merge conflicts' because we won't get CICD runs without those resolved.
| { | ||
| add_method(DMR_RESPONSE, dap_build_dmr); | ||
| add_method(DAP4DATA_RESPONSE, dap_build_dap4data); | ||
| add_method(DAS_RESPONSE, dap_build_das); |
There was a problem hiding this comment.
I think we should remove the constants DMRPP_USE_TRANSFER_THREADS_KEY so those don't linger and confuse us. We probably want to edit the various *.conf files (the dmrpp.conf.in and the ones used for the integration tests) too.
|
@dh-opendap The conflict in DmrppRequestHandler.cc looks bad, but I think it's only that some of the text got indented and there are no actual differences there. It's easy for this to happen since we wrote the code without indenting for namespaces and most IDEs do indent the stuff inside a namespace dmrpp { ... } block. |
kyang2014
left a comment
kyang2014
left a comment
There was a problem hiding this comment.
I suggest you to merge the master to your branch and resolve all the merge conflicts first.
|
There are some sonar cloud code smells and I think they are easy to fix. |
|
|
|
3 participants
Description
Reference ticket: HYRAX-1965
TODO
Tasks