Conversation
hannahilea
requested review from
jgallagher59701 and
ndp-opendap
and removed request for
jgallagher59701 and
ndp-opendap
|
Requested review too soon, my build still fails! In the interim, a review of the overall approach would be welcome---it was easy to make the change and open a PR, but we can just as easily close it without merging if folks disagree on the approach. I don't have super strong feelings about this, just general "code steward" ones. |
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
We can remove this as long as we can get the code back. I'm assuming that we can look in the git log, search for a commit message that says "We Removed RPM Support" or something equivalent and checkout that commit (or extract files from that commit (I know that we can do those things; I want to be sure we can find the commit).
I can see a fair number of commits having to do with RPMs:
git log --oneline --grep RPM
...
There are 57.
So... we have to make sure the commit message is clear.
ndp-opendap
left a comment
ndp-opendap
left a comment
There was a problem hiding this comment.
OK. But it still scares me...
|
|
|
3 participants
Description
As of OPENDAP/hyrax-docker#107 we no longer require bes RPMs for our hyrax docker images.
In an upcoming set of changes (#1183), it will no longer be possible to build RPMs, as we were unable to create static RPMs that include the requisite AWS libraries.
Let's remove the bes RPM builds, so that if we ever want to add them back, we can see what was removed in a single place (here!).
We could alternatively hold off on this change (or not do it at all) and merely comment out the RPM builds in the .travis.yml file when we merge the AWS changes. I think removing everything outright would help our code base stay clean relative to the functionality it enables, however.
Note that I did not remove RPM builds for any modules; I only touched the top-level bes builds.
Tasks
Tests added/updated