Skip to content

Draft Checksums Change#34

Draft
ndp-opendap wants to merge 9 commits intomainfrom
checksums_update
Draft

Draft Checksums Change#34
ndp-opendap wants to merge 9 commits intomainfrom
checksums_update

Conversation

@ndp-opendap
Copy link
Copy Markdown
Contributor

@ndp-opendap ndp-opendap commented Jul 11, 2025

  • For the dap4 data response, defines bit 3 (the fourth bit) of the first chunk header as a flag to indicate the presences of checksums in the serialized data.
  • Small reorganization to the Checksums discussion to capture the new checksums flag.

Copy link
Copy Markdown
Collaborator

@DennisHeimbigner DennisHeimbigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need to change line 1854?

with the encoding 0 = data, 1 = end, 2 = error, 4 = Little-Endian */

@ndp-opendap ndp-opendap requested a review from Mikejmnez August 27, 2025 22:08
@ndp-opendap
Copy link
Copy Markdown
Contributor Author

ndp-opendap commented Aug 27, 2025

Do you also need to change line 1854?

with the encoding 0 = data, 1 = end, 2 = error, 4 = Little-Endian */

Yes thanks, change made...

Copy link
Copy Markdown
Member

@jgallagher59701 jgallagher59701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change. Ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants