HYRAX-2041: Fix lingering paths in bes.conf#144
Merged
hannahilea merged 2 commits intomasterfrom Mar 20, 2026
Merged
Conversation
Contributor
Author
|
Turns out this was an inherited issue from the bes_core docker image. I've patched it here so that we don't need to wait for an upstream fix, and then I'll go fix it over there too. |
hannahilea
requested review from
ndp-opendap
and removed request for
ndp-opendap
ndp-opendap
approved these changes
Mar 19, 2026
Collaborator
ndp-opendap
left a comment
ndp-opendap
left a comment
There was a problem hiding this comment.
One comment, all good.
| # Patch a mistake that was introduced at the bes_core layer | ||
| # After it's fixed in the bes repo, this line will be redundant | ||
| # and we can remove it | ||
| RUN cp -r /share/bes /usr/share/bes \ |
Collaborator
There was a problem hiding this comment.
Do we need a ticket to remind us?
Contributor
Author
There was a problem hiding this comment.
the original HYRAX-2041 is still open, so in this case instead of filing a ticket i'm going to make this upstream fix immediately and not close the ticket until it is done (if i do end up wanting to close it sooner, i'll file a ticket for any clean-up that isn't complete).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...in #142, forgot a /usr/ prefix in several places.