Fix IP validation in digital signature file download (CIDR support)#305
Merged
jekuaitk merged 4 commits intoOS2Forms:developfrom Mar 25, 2026
Merged
Conversation
cableman
force-pushed
the
feature/digital_signature_ips
branch
2 times, most recently
from
7631097 to
83921fd
Compare
cableman
force-pushed
the
feature/digital_signature_ips
branch
from
83921fd to
de2282a
Compare
jekuaitk
reviewed
Feb 18, 2026
modules/os2forms_digital_signature/os2forms_digital_signature.module
Outdated
Show resolved
Hide resolved
jekuaitk
approved these changes
Feb 18, 2026
modules/os2forms_digital_signature/os2forms_digital_signature.module
Outdated
Show resolved
Hide resolved
Contributor
|
Hej @ds-bellcom I forbindelse med digital signatur blev det nødvendigt for os at tillade IP-ranges. Vil i tage et kig på dette PR som udvider logikken for tilladte IP'er til at kunne håndtere CIDR/IP-ranges? |
Contributor
|
@jekuaitk selvfølgelig. Jeg har planlagt det hos Stan i næste uge. |
stankut
requested changes
Mar 17, 2026
modules/os2forms_digital_signature/os2forms_digital_signature.module
Outdated
Show resolved
Hide resolved
modules/os2forms_digital_signature/os2forms_digital_signature.module
Outdated
Show resolved
Hide resolved
modules/os2forms_digital_signature/os2forms_digital_signature.module
Outdated
Show resolved
Hide resolved
modules/os2forms_digital_signature/os2forms_digital_signature.services.yml
Show resolved
Hide resolved
Contributor
|
Same story as #301 (comment) - fixes have been made and we would like a review :-) |
stankut
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allow us to filter on CIDR, which is useful in a dynamic setup where the IP may change