Skip to content

Update image links#55

Merged
rmobis merged 2 commits intoOSRS-Taskman:mainfrom
RedSparr0w:sparr0w/images-detail
Mar 23, 2026
Merged

Update image links#55
rmobis merged 2 commits intoOSRS-Taskman:mainfrom
RedSparr0w:sparr0w/images-detail

Conversation

@RedSparr0w
Copy link
Copy Markdown
Contributor

Change to high detail image where available
Remove extra link details to simplify image links

-			"imageLink": "https://oldschool.runescape.wiki/images/thumb/3/36/Crawling_hand_(item)_detail.png/140px-Crawling_hand_(item)_detail.png",
+			"imageLink": "https://oldschool.runescape.wiki/images/Crawling_hand_(item)_detail.png",

Tested all images load successfully

Change to high detail image where available
Remove extra link details to simplify image links
Tested all images load successfully
@RedSparr0w
Copy link
Copy Markdown
Contributor Author

Can test all images load and see a visual preview using the attached file in the root of the project
viewer.html

@rmobis
Copy link
Copy Markdown
Member

rmobis commented Mar 23, 2026

The reason we have links in the format https://oldschool.runescape.wiki/images/thumb/Mooleta_detail.png/320px-Mooleta_detail.png (other formats are legacy and haven't been updated) is because it allows us to specify the size and that decreases the bandwidth required to load the image. Do you need more than 320px resolution?

Also, we have a CI step to validate all links, they all passed.

@RedSparr0w
Copy link
Copy Markdown
Contributor Author

Ahh sweet, want me to put them all in the other format then with the px specification?
default to 320px?

@rmobis
Copy link
Copy Markdown
Member

rmobis commented Mar 23, 2026

Ahh sweet, want me to put them all in the other format then with the px specification? default to 320px?

Yes, if you could do that, I'd appreciate it. It's something I've been meaning to do at some point.

@RedSparr0w
Copy link
Copy Markdown
Contributor Author

Sweet, all updated, should be good now I think

@rmobis rmobis merged commit 34c3237 into OSRS-Taskman:main Mar 23, 2026
6 checks passed
@rmobis
Copy link
Copy Markdown
Member

rmobis commented Mar 23, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants