Create an audit log for objects (attempt #2) by drkitty · Pull Request #944 · OSU-Net/cyder

drkitty · 2015-03-30T23:56:56Z

Supersedes PR #755.

…attern

Conflicts: cyder/cydns/address_record/forms.py cyder/cydns/cname/forms.py cyder/cydns/mx/forms.py cyder/cydns/nameserver/models.py cyder/cydns/ptr/models.py cyder/cydns/srv/forms.py cyder/cydns/sshfp/forms.py cyder/cydns/txt/forms.py

…n updated from blank.

…e displayed in log, fix broken SRV serializer.

…iance.

Conflicts: cyder/base/views.py cyder/cydhcp/interface/dynamic_intr/models.py cyder/cydhcp/interface/static_intr/models.py cyder/cydhcp/network/models.py cyder/cydhcp/range/models.py cyder/cydhcp/site/models.py cyder/cydhcp/views.py cyder/cydhcp/vlan/models.py cyder/cydhcp/vrf/models.py cyder/cydhcp/workgroup/models.py cyder/cydns/address_record/models.py cyder/cydns/cname/models.py cyder/cydns/domain/forms.py cyder/cydns/domain/models.py cyder/cydns/mx/models.py cyder/cydns/nameserver/models.py cyder/cydns/nameserver/urls.py cyder/cydns/ptr/models.py cyder/cydns/soa/models.py cyder/cydns/srv/models.py cyder/cydns/sshfp/models.py cyder/cydns/txt/models.py

…bject_audit_log

Conflicts: cyder/cydhcp/interface/dynamic_intr/models.py cyder/cydhcp/interface/static_intr/models.py cyder/cydhcp/network/models.py cyder/cydhcp/range/models.py cyder/cydhcp/site/models.py cyder/cydhcp/vlan/models.py cyder/cydhcp/vrf/models.py cyder/cydhcp/workgroup/models.py cyder/cydns/cname/models.py cyder/cydns/domain/models.py cyder/cydns/mx/models.py cyder/cydns/nameserver/models.py cyder/cydns/ptr/models.py cyder/cydns/srv/models.py cyder/cydns/sshfp/models.py cyder/cydns/txt/models.py

…og_test_merge Conflicts: cyder/cydhcp/interface/static_intr/models.py

drkitty · 2015-04-28T19:31:47Z

...except for the merge, which I'll take a look at

Conflicts: cyder/cydhcp/network/models.py cyder/cydhcp/range/models.py cyder/cydhcp/views.py cyder/cydns/nameserver/urls.py cyder/cydns/nameserver/views.py cyder/settings/local.py-travis

drkitty · 2015-04-28T20:02:16Z

The range log isn't displayed on range detail pages.

drkitty · 2015-04-28T20:07:55Z

Same with the site log. Maybe there's a good reason to keep a log and not show it, but I don't know what it is.

drkitty · 2015-04-28T20:50:01Z

Something's wrong with DNSForm or Django.

drkitty · 2015-04-30T23:19:18Z

So I know this solution is gross and just adds to the mountain of ad-hoc mutation in Cyder, but we've accumulated so many workarounds for questionable Django design decisions that it would be difficult to solve this problem any other way.

murrown · 2015-05-13T22:09:59Z

Some quick notes...

Systems don't track name changes
DNS record's views aren't tracked (perhaps all m2m fields aren't tracked?)
DNS record's container isn't tracked

drkitty · 2015-05-14T23:15:05Z

That's intentional. I remember someone okaying it.
Probably should be fixed. I'll look into how difficult that would be.
Weird.

murrown · 2015-05-15T22:33:14Z

It wouldn't be difficult to track system names though, right? Anyone know the rationale for not tracking system names? @akeym

murrown · 2015-05-15T22:35:30Z

I can't update dynamic interfaces. Unknown internal server error.

BTW, this is definitely on this branch... I can update the interface on master just fine.

akeym · 2015-05-15T22:37:05Z

I'm not sure what the reasoning is, if any. And now that they have ctnrs...

murrown · 2015-05-15T22:38:45Z

Yeah, speaking of containers, that might be the reason why I can't update interfaces on this branch. Maybe my database is using the wrong schema, although I did run a schema migration to check...

drkitty · 2015-05-28T20:28:02Z

Saving interfaces works again.

drkitty · 2015-06-25T20:42:20Z

I think maybe we should just merge this and I can fix the remaining issues later.

akeym · 2015-06-25T20:43:59Z

Have we done some simple stress testing to see what happens after you
change an object more than the amount of times we track? how about
artificially making a bunch of change history :) I dunno, I really don't
want to deploy something that's broken or will make Cyder implode.

On Thu, Jun 25, 2015 at 1:42 PM, drkitty notifications@github.com wrote:

I think maybe we should just merge this and I can fix the remaining issues
later.

—
Reply to this email directly or view it on GitHub
#944 (comment).

drkitty · 2015-06-25T20:48:36Z

Sure, I can do that.

zeeman and others added 30 commits August 22, 2014 15:08

Get logging working. (No UI stuff)

695a572

User can view changes to Dynamic Interface.

3ea399b

Log the actual user making a change instead of the user they've become

bd63fe6

Add logging to all cydhcp models

cd1d6ae

Start custom DynamicInterface serializer for user-friendly logging

309c012

TEMP start implementing DRF-based serializers

127dfe6

Implement DRF-based serializers for logging, hide log fields from forms.

ca7b89b

Undo some dumb mistakes

3a3cbd9

Remove VRF logging

827236a

Add DRF-based serializers for logging

8b840c1

Remove pudb.set_trace

e8d5c82

TEMP? Replace log with nicer-looking table view

49375c4

Display only the previous values of fields that are changed.

619f3f4

Use nicer dates, fix various things

1ba2713

Add (mysteriously non-functional) CNAME detail view

2021b54

Attempt alternative (and also non-functional) CNAME detail view url p…

f9efb5d

…attern

Add CNAME and NS detail views, attempt to add logging to view changes.

0e7828d

Merge branch 'master' into object_audit_log_temp

28e3de7

Conflicts: cyder/cydns/address_record/forms.py cyder/cydns/cname/forms.py cyder/cydns/mx/forms.py cyder/cydns/nameserver/models.py cyder/cydns/ptr/models.py cyder/cydns/srv/forms.py cyder/cydns/sshfp/forms.py cyder/cydns/txt/forms.py

Fix bug where m2m relations were not saved.

be7d779

Add some extra serializer fields, enable logging when a field has bee…

fa9af0b

…n updated from blank.

Add necessary DNS detail views, change how previously blank fields ar…

e740436

…e displayed in log, fix broken SRV serializer.

Remove pointless fields from DynamicInterfaceLogSerializer

2a0db66

Don't add a log entry if no changes will be logged. Better PEP8 compl…

f8eadd3

…iance.

Make serializer field names and order closer to UI.

c4c9d34

Make log serializers even closer to UI.

9183036

Merge remote-tracking branch 'drkitty/object_audit_log+master' into o…

0d89bd0

…bject_audit_log

Merge branch 'master' of github.com:OSU-Net/cyder into object_audit_l…

00c4352

…og_test_merge Conflicts: cyder/cydhcp/interface/static_intr/models.py

Don't import settings from cyder.settings.local, improve idiomaticity

105ee6a

drkitty added 2 commits April 28, 2015 12:40

Merge remote-tracking branch 'upstream/master' into object-audit-log

83f9bed

Conflicts: cyder/cydhcp/network/models.py cyder/cydhcp/range/models.py cyder/cydhcp/views.py cyder/cydns/nameserver/urls.py cyder/cydns/nameserver/views.py cyder/settings/local.py-travis

Clean up after merge

a18d837

Fix save_m2m invocation

857c06a

drkitty removed the please review label Apr 28, 2015

Fix save_m2m error, hopefully

7bb6ac3

drkitty added the please review label May 7, 2015

drkitty assigned murrown and unassigned akeym May 12, 2015

murrown removed the please review label May 18, 2015

drkitty added 2 commits May 20, 2015 17:08

Merge branch 'master' into object-audit-log

7e14d89

Fix issue with saving interfaces

dab6c2d

drkitty added please review and removed please review labels May 26, 2015

Remove unnecessary whitespace

3f6433b

Remove references to now-unused attribute

53a46a5

Conversation

drkitty commented Mar 30, 2015

Uh oh!

drkitty commented Apr 28, 2015

Uh oh!

drkitty commented Apr 28, 2015

Uh oh!

drkitty commented Apr 28, 2015

Uh oh!

drkitty commented Apr 28, 2015

Uh oh!

drkitty commented Apr 30, 2015

Uh oh!

murrown commented May 13, 2015

Uh oh!

drkitty commented May 14, 2015

Uh oh!

murrown commented May 15, 2015

Uh oh!

murrown commented May 15, 2015

Uh oh!

akeym commented May 15, 2015

Uh oh!

murrown commented May 15, 2015

Uh oh!

drkitty commented May 28, 2015

Uh oh!

drkitty commented Jun 25, 2015

Uh oh!

akeym commented Jun 25, 2015

Uh oh!

drkitty commented Jun 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants